[PATCH] d3dx9_36: Fix some spec file entries (try 2)

Matteo Bruni matteo.mystral at gmail.com
Tue Jan 14 16:12:19 CST 2020


On Tue, Jan 14, 2020, 18:31 Zebediah Figura <z.figura12 at gmail.com> wrote:
>
> On 1/14/20 11:18 AM, Matteo Bruni wrote:
> > With the subject prefix changed to simply "d3dx9:" this is:
> > Signed-off-by: Matteo Bruni <mbruni at codeweavers.com>
> > ---
> > Idea for a follow up: some of the resource functions use str / wstr
> > for the resource name, others don't. I don't think it's correct to
> > treat it as a string in general since resources can also be identified
> > by integers (see IS_INTRESOURCE). This is to say, a patch replacing
> > those str / wstr with ptr would be nice...
> >
>
> I believe our relay traces can actually deal with that; see uses of
> IS_INTARG in ntdll/relay.c.

Oh indeed, nice. Then I guess we should consistently use str / wstr
for those instead.



More information about the wine-devel mailing list