[PATCH 3/3] ddraw/tests: Perform the 2nd getdc-in-lock test on the mipmap surface.

Henri Verbeet hverbeet at gmail.com
Tue Jan 21 05:12:23 CST 2020

On Tue, 7 Jan 2020 at 15:10, Stefan Dösinger <stefan at codeweavers.com> wrote:
> The way it stands it is just a repeat of the test a few lines earlier.
> I guess this was the original intention. And no, it does not affect the
> E_FAIL on the Geforce 9600.

It was a port of the equivalent d3d9 test. In the d3d9 test the
GetDC() call fails, and the second instance of this sequence tests
calling ReleaseDC() after the failed GetDC(), while the first instance
doesn't, mostly to avoid the possibility of the invalid ReleaseDC()
breaking subsequent tests. The second instance of the sequence in the
ddraw tests could have been removed, but at the time I felt it was
easier to compare the ddraw and d3d9 tests if it was kept.

More information about the wine-devel mailing list