[PATCH v2] dmime: IDirectMusicPerformance8_FreePMsg Release the unknown pointer.

Michael Stefaniuc mstefani at winehq.org
Tue Jan 21 15:24:46 CST 2020


From: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
Signed-off-by: Michael Stefaniuc <mstefani at winehq.org>
---
v2: resend (Deferred)


 dlls/dmime/performance.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/dmime/performance.c b/dlls/dmime/performance.c
index 2124c1fe35..3dd54a6cb6 100644
--- a/dlls/dmime/performance.c
+++ b/dlls/dmime/performance.c
@@ -531,7 +531,9 @@ static HRESULT WINAPI IDirectMusicPerformance8Impl_FreePMsg(IDirectMusicPerforma
   DMUS_ItemRemoveFromQueue( This, pItem );
   LeaveCriticalSection(&This->safe);
 
-  /** TODO: see if we should Release the pItem->pMsg->punkUser and others Interfaces */
+  if (pPMSG->punkUser)
+    IUnknown_Release(pPMSG->punkUser);
+
   HeapFree(GetProcessHeap(), 0, pItem);  
   return S_OK;
 }
-- 
2.24.1




More information about the wine-devel mailing list