[PATCH] testbot/UpdateTaskLogs: Fix reporting log access errors.

Francois Gouget fgouget at codeweavers.com
Wed Jan 22 04:12:13 CST 2020


Use the error message returned by ParseWineTestReport() when it could
not open the report instead of recreating it from scratch.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---

This is the same fix as the previous WineRun* patch. But I had already 
copy/pasted the bad code apparently :-(

 testbot/bin/UpdateTaskLogs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testbot/bin/UpdateTaskLogs b/testbot/bin/UpdateTaskLogs
index ae3b305388..ca9bf44a37 100755
--- a/testbot/bin/UpdateTaskLogs
+++ b/testbot/bin/UpdateTaskLogs
@@ -193,7 +193,7 @@ sub BuildErrFile($$$$)
   my ($TestUnitCount, $TimeoutCount, $LogFailures, $LogErrors) = ParseWineTestReport("$Dir/$ReportName", $IsWineTest, $TaskTimedOut);
   if (!defined $LogFailures and @$LogErrors == 1)
   {
-    return "Unable to open '$TaskKey/$ReportName' for reading: $!";
+    return "$TaskKey: $LogErrors->[0]";
   }
   return undef if (!@$LogErrors);
 
-- 
2.20.1



More information about the wine-devel mailing list