[PATCH 1/4] d3d9/tests: Test more formats in srgbtexture_test().

Stefan Dösinger stefandoesinger at gmail.com
Wed Jan 22 06:16:27 CST 2020

Am 21.01.20 um 21:17 schrieb Paul Gofman:
> If I did not miss something important here, the unfortunate _SRGB8 GL
> format may only affect things for d3d9 if application is actually 
> trying to use 16 bit format as SRGB

utils.c, check_fbo_compat() and the internalformat_query2 equivalents:

if (gl_info->supported[EXT_TEXTURE_SRGB_DECODE])
    format->internal = format->srgb_internal;

That's because EXT_texture_sRGB_decode can only switch sRGB off for sRGB
textures, it can't switch it on for RGB textures. So we create all as
sRGB and switch it off until the app enables it.

We have a fallback codepath in case EXT_TEXTURE_SRGB_DECODE is not
available. We'd have to enable this fallback codepath for 16 bit
formats, otherwise all 16 bit RGB textures will have the 32 bit
conversion penalty even for apps that don't use sRGB.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200122/c5e2c8eb/attachment.sig>

More information about the wine-devel mailing list