[PATCH 2/7] ddraw/tests: Pass in device to create with create_device.

[Jeff Smith]

On Wed, Jan 22, 2020 at 11:32 AM Matteo Bruni <matteo.mystral at gmail.com> wrote:
>
> > On Wed, Jan 22, 2020 at 9:54 AM Matteo Bruni <matteo.mystral at gmail.com> wrote:
> > >
> > > On Fri, Dec 13, 2019 at 6:01 AM Jeff Smith <whydoubt at gmail.com> wrote:
> > > Just an idea: what about introducing a create_device_riid() and keep
> > > create_device() for the HAL case (i.e. rename your create_device() to
> > > create_device_riid() and create_device_hal() to create_device())? That
> > > way you don't have to change all the current callers of
> > > create_device().
> >
> > Hi Matteo,
> >
> > I had considered exactly that originally, then thought perhaps the
> > more-accurate names would be worth the noise.
> > I am fine with changing it back.
> > Before I resubmit the patchset, did you have any other feedback on it?
> >
> > Thanks,
> > Jeff
>
> I don't know that it necessarily needs to be changed back, just
> something that I noticed in passing when looking at your patches a
> while back. Henri might have a stronger opinion though.

OK, I suppose I will hold off on that for now then.

> I don't think I had anything else to say, although it's been a while
> since I looked... Skimming through the patches very quickly now, the
> "while (IDirectDrawPalette_Release(palette) > refcount) ;" in patch
> 5/7 looks particularly obnoxious but I imagine also unavoidable (and
> relevant, in the sense "ah, that might be why some games did exactly
> that in ddraw back then...").

Yeah, that one was a bit frustrating... all the appropriate Release calls
had been made, and several objects still wouldn't get to refcount 0.