[PATCH 3/5] ddraw/tests: WinXP drivers don't necessarily set dib.dsBm.bmBits.
Stefan Dösinger
stefan at codeweavers.com
Thu Jan 23 03:45:41 CST 2020
Signed-off-by: Stefan Dösinger <stefan at codeweavers.com>
---
A user in #winehackers helped me confirm that Nvidia GPUs on Windows XP
behave in the same way. It is possible to run Windows 7 with XP drivers,
but I don't have a setup like that. It is possible that this is a property
of pre-WDDM drivers rather than XP itself, but the test codes it as though
it is a WinXP property.
Yes, d3d9 is affected too, but our d3d9 test_caps() is not because it
creates sysmem surfaces.
---
dlls/ddraw/tests/ddraw1.c | 14 +++++++++++---
dlls/ddraw/tests/ddraw2.c | 14 +++++++++++---
dlls/ddraw/tests/ddraw4.c | 14 +++++++++++---
dlls/ddraw/tests/ddraw7.c | 14 +++++++++++---
4 files changed, 44 insertions(+), 12 deletions(-)
diff --git a/dlls/ddraw/tests/ddraw1.c b/dlls/ddraw/tests/ddraw1.c
index faec17742e7..fc104273d02 100644
--- a/dlls/ddraw/tests/ddraw1.c
+++ b/dlls/ddraw/tests/ddraw1.c
@@ -9805,7 +9805,7 @@ static void test_getdc(void)
DDSURFACEDESC surface_desc, map_desc;
DDSCAPS caps = {DDSCAPS_COMPLEX};
IDirectDraw *ddraw;
- unsigned int i;
+ unsigned int i, screen_bpp;
HWND window;
HDC dc, dc2;
HRESULT hr;
@@ -9869,6 +9869,11 @@ static void test_getdc(void)
hr = IDirectDraw_SetCooperativeLevel(ddraw, window, DDSCL_NORMAL);
ok(SUCCEEDED(hr), "Failed to set cooperative level, hr %#x.\n", hr);
+ surface_desc.dwSize = sizeof(surface_desc);
+ hr = IDirectDraw_GetDisplayMode(ddraw, &surface_desc);
+ ok(SUCCEEDED(hr), "Failed to get display mode, hr %#x.\n", hr);
+ screen_bpp = U1(surface_desc.ddpfPixelFormat).dwRGBBitCount;
+
for (i = 0; i < ARRAY_SIZE(test_data); ++i)
{
memset(&surface_desc, 0, sizeof(surface_desc));
@@ -9927,8 +9932,11 @@ static void test_getdc(void)
ok(dib.dsBm.bmBitsPixel == U1(test_data[i].format).dwRGBBitCount,
"Got unexpected bit count %d for format %s.\n",
dib.dsBm.bmBitsPixel, test_data[i].name);
- ok(!!dib.dsBm.bmBits, "Got unexpected bits %p for format %s.\n",
- dib.dsBm.bmBits, test_data[i].name);
+ /* Windows XP sets bmBits == NULL for formats that match the screen at least on my r200 GPU. I
+ * suspect this applies to all HW accelerated pre-WDDM drivers because they can handle gdi access
+ * to ddraw surfaces themselves instead of going through a sysmem DIB section. */
+ ok(!!dib.dsBm.bmBits || broken(!pDwmIsCompositionEnabled && dib.dsBm.bmBitsPixel == screen_bpp),
+ "Got unexpected bits %p for format %s.\n", dib.dsBm.bmBits, test_data[i].name);
ok(dib.dsBmih.biSize == sizeof(dib.dsBmih), "Got unexpected size %u for format %s.\n",
dib.dsBmih.biSize, test_data[i].name);
diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c
index 28e97676456..a14df435b25 100644
--- a/dlls/ddraw/tests/ddraw2.c
+++ b/dlls/ddraw/tests/ddraw2.c
@@ -10507,7 +10507,7 @@ static void test_getdc(void)
DDSURFACEDESC surface_desc, map_desc;
DDSCAPS caps = {DDSCAPS_COMPLEX};
IDirectDraw2 *ddraw;
- unsigned int i;
+ unsigned int i, screen_bpp;
HWND window;
HDC dc, dc2;
HRESULT hr;
@@ -10571,6 +10571,11 @@ static void test_getdc(void)
hr = IDirectDraw2_SetCooperativeLevel(ddraw, window, DDSCL_NORMAL);
ok(SUCCEEDED(hr), "Failed to set cooperative level, hr %#x.\n", hr);
+ surface_desc.dwSize = sizeof(surface_desc);
+ hr = IDirectDraw2_GetDisplayMode(ddraw, &surface_desc);
+ ok(SUCCEEDED(hr), "Failed to get display mode, hr %#x.\n", hr);
+ screen_bpp = U1(surface_desc.ddpfPixelFormat).dwRGBBitCount;
+
for (i = 0; i < ARRAY_SIZE(test_data); ++i)
{
memset(&surface_desc, 0, sizeof(surface_desc));
@@ -10629,8 +10634,11 @@ static void test_getdc(void)
ok(dib.dsBm.bmBitsPixel == U1(test_data[i].format).dwRGBBitCount,
"Got unexpected bit count %d for format %s.\n",
dib.dsBm.bmBitsPixel, test_data[i].name);
- ok(!!dib.dsBm.bmBits, "Got unexpected bits %p for format %s.\n",
- dib.dsBm.bmBits, test_data[i].name);
+ /* Windows XP sets bmBits == NULL for formats that match the screen at least on my r200 GPU. I
+ * suspect this applies to all HW accelerated pre-WDDM drivers because they can handle gdi access
+ * to ddraw surfaces themselves instead of going through a sysmem DIB section. */
+ ok(!!dib.dsBm.bmBits || broken(!pDwmIsCompositionEnabled && dib.dsBm.bmBitsPixel == screen_bpp),
+ "Got unexpected bits %p for format %s.\n", dib.dsBm.bmBits, test_data[i].name);
ok(dib.dsBmih.biSize == sizeof(dib.dsBmih), "Got unexpected size %u for format %s.\n",
dib.dsBmih.biSize, test_data[i].name);
diff --git a/dlls/ddraw/tests/ddraw4.c b/dlls/ddraw/tests/ddraw4.c
index b3983468395..b0b70cc2621 100644
--- a/dlls/ddraw/tests/ddraw4.c
+++ b/dlls/ddraw/tests/ddraw4.c
@@ -12488,7 +12488,7 @@ static void test_getdc(void)
IDirectDrawSurface4 *surface, *surface2, *tmp;
DDSURFACEDESC2 surface_desc, map_desc;
IDirectDraw4 *ddraw;
- unsigned int i;
+ unsigned int i, screen_bpp;
HWND window;
HDC dc, dc2;
HRESULT hr;
@@ -12552,6 +12552,11 @@ static void test_getdc(void)
hr = IDirectDraw4_SetCooperativeLevel(ddraw, window, DDSCL_NORMAL);
ok(SUCCEEDED(hr), "Failed to set cooperative level, hr %#x.\n", hr);
+ surface_desc.dwSize = sizeof(surface_desc);
+ hr = IDirectDraw4_GetDisplayMode(ddraw, &surface_desc);
+ ok(SUCCEEDED(hr), "Failed to get display mode, hr %#x.\n", hr);
+ screen_bpp = U1(U4(surface_desc).ddpfPixelFormat).dwRGBBitCount;
+
for (i = 0; i < ARRAY_SIZE(test_data); ++i)
{
memset(&surface_desc, 0, sizeof(surface_desc));
@@ -12611,8 +12616,11 @@ static void test_getdc(void)
ok(dib.dsBm.bmBitsPixel == U1(test_data[i].format).dwRGBBitCount,
"Got unexpected bit count %d for format %s.\n",
dib.dsBm.bmBitsPixel, test_data[i].name);
- ok(!!dib.dsBm.bmBits, "Got unexpected bits %p for format %s.\n",
- dib.dsBm.bmBits, test_data[i].name);
+ /* Windows XP sets bmBits == NULL for formats that match the screen at least on my r200 GPU. I
+ * suspect this applies to all HW accelerated pre-WDDM drivers because they can handle gdi access
+ * to ddraw surfaces themselves instead of going through a sysmem DIB section. */
+ ok(!!dib.dsBm.bmBits || broken(!pDwmIsCompositionEnabled && dib.dsBm.bmBitsPixel == screen_bpp),
+ "Got unexpected bits %p for format %s.\n", dib.dsBm.bmBits, test_data[i].name);
ok(dib.dsBmih.biSize == sizeof(dib.dsBmih), "Got unexpected size %u for format %s.\n",
dib.dsBmih.biSize, test_data[i].name);
diff --git a/dlls/ddraw/tests/ddraw7.c b/dlls/ddraw/tests/ddraw7.c
index 986a1f3a127..b31f942c112 100644
--- a/dlls/ddraw/tests/ddraw7.c
+++ b/dlls/ddraw/tests/ddraw7.c
@@ -12476,7 +12476,7 @@ static void test_getdc(void)
IDirectDrawSurface7 *surface, *surface2, *tmp;
DDSURFACEDESC2 surface_desc, map_desc;
IDirectDraw7 *ddraw;
- unsigned int i;
+ unsigned int i, screen_bpp;
HWND window;
HDC dc, dc2;
HRESULT hr;
@@ -12540,6 +12540,11 @@ static void test_getdc(void)
hr = IDirectDraw7_SetCooperativeLevel(ddraw, window, DDSCL_NORMAL);
ok(SUCCEEDED(hr), "Failed to set cooperative level, hr %#x.\n", hr);
+ surface_desc.dwSize = sizeof(surface_desc);
+ hr = IDirectDraw7_GetDisplayMode(ddraw, &surface_desc);
+ ok(SUCCEEDED(hr), "Failed to get display mode, hr %#x.\n", hr);
+ screen_bpp = U1(U4(surface_desc).ddpfPixelFormat).dwRGBBitCount;
+
for (i = 0; i < ARRAY_SIZE(test_data); ++i)
{
memset(&surface_desc, 0, sizeof(surface_desc));
@@ -12599,8 +12604,11 @@ static void test_getdc(void)
ok(dib.dsBm.bmBitsPixel == U1(test_data[i].format).dwRGBBitCount,
"Got unexpected bit count %d for format %s.\n",
dib.dsBm.bmBitsPixel, test_data[i].name);
- ok(!!dib.dsBm.bmBits, "Got unexpected bits %p for format %s.\n",
- dib.dsBm.bmBits, test_data[i].name);
+ /* Windows XP sets bmBits == NULL for formats that match the screen at least on my r200 GPU. I
+ * suspect this applies to all HW accelerated pre-WDDM drivers because they can handle gdi access
+ * to ddraw surfaces themselves instead of going through a sysmem DIB section. */
+ ok(!!dib.dsBm.bmBits || broken(!pDwmIsCompositionEnabled && dib.dsBm.bmBitsPixel == screen_bpp),
+ "Got unexpected bits %p for format %s.\n", dib.dsBm.bmBits, test_data[i].name);
ok(dib.dsBmih.biSize == sizeof(dib.dsBmih), "Got unexpected size %u for format %s.\n",
dib.dsBmih.biSize, test_data[i].name);
--
2.24.1
More information about the wine-devel
mailing list