test_compressed_surface_stretch fails on r200 GPUs

[Stefan Dösinger]

Hi Paul,

In my quest to squash ddraw test failures on my hardware lab I have run
into a recently added problem. Maybe you still have an active enough
memory of the test code that you can help me understand the failure.

The system is a 2003-era laptop with an ATI Mobility Radeon 9000 running
windows XP. The test failures are in the attached ddraw7.txt file. I ran
the test with some minimal modifications, see ddraw7.diff.

My gut feeling is that this is not simply a color precision issue - the
values are pretty far apart, especially for 16 bit surfaces. Yet,
something is apparently going right. The blit happens and the result at
least resembles the expected results.

It makes sense to me that only the sysmem->vidmem blit is affected as
that's the most likely case to be accelerated by the driver. Could the
driver handle the src rectangle incorrectly?

My cheap way to fix it would be to add something like
broken(ddraw_is_amd() && color == 0x8019), but if we can find a way to
keep the test intact on this hardware that would be better.

Cheers,
Stefan
-------------- next part --------------
ddraw7.c:17156: Driver string: "ati2dvag.dll"
ddraw7.c:17157: Description string: "Mobility Radeon 9000"
ddraw7.c:17158: Driver version 0.0.0.0
ddraw7.c:17115: Test failed: Test (1, 4, 0, 2), x 4, y 2, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 0, 2), x 5, y 2, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 0, 2), x 6, y 2, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 0, 2), x 7, y 2, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 0, 2), x 4, y 3, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 0, 2), x 5, y 3, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 0, 2), x 6, y 3, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 0, 2), x 7, y 3, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 1, 2), x 4, y 2, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 1, 2), x 5, y 2, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 1, 2), x 6, y 2, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 1, 2), x 7, y 2, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 1, 2), x 4, y 3, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 1, 2), x 5, y 3, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 1, 2), x 6, y 3, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 1, 2), x 7, y 3, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 2, 2), x 4, y 2, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 2, 2), x 5, y 2, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 2, 2), x 6, y 2, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 2, 2), x 7, y 2, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 2, 2), x 4, y 3, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 2, 2), x 5, y 3, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 2, 2), x 6, y 3, got unexpected colour 0x8019.
ddraw7.c:17115: Test failed: Test (1, 4, 2, 2), x 7, y 3, got unexpected colour 0x8019.
0f94:ddraw7: 5052 tests executed (0 marked as todo, 24 failures), 0 skipped.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ddraw7.diff
Type: text/x-patch
Size: 1395 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200123/9bf88c11/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200123/9bf88c11/attachment-0001.sig>