[PATCH 3/5] d3d9: Handle multisample depth resolve in d3d9_device_SetRenderState().

Zebediah Figura z.figura12 at gmail.com
Fri Jan 24 11:35:56 CST 2020

On 1/24/20 8:43 AM, Henri Verbeet wrote:
> On Thu, 23 Jan 2020 at 02:30, Zebediah Figura <z.figura12 at gmail.com> wrote:
>> +    if ((enum wined3d_format_id)format == WINED3DFMT_RESZ)
> That works, but if the idea behind it is that we would be able to
> remove WINED3DFMT_RESZ from wined3d after the d3d8 version is done, we
> may just as add a "#define D3DFMT_RESZ MAKEFOURCC('R','E','S','Z')",
> and get rid of the cast.

Will do, thanks.

> Should we also check for D3DUSAGE_RENDERTARGET and D3DRTYPE_SURFACE here?

Maybe. Neither Windows nor Wine currently limits the check quite that 
far, though (e.g. 0 and D3DRTYPE_TEXTURE respectively works), and it 
seems easier to me just not to check those flags at all.

More information about the wine-devel mailing list