[PATCH] add: SetEnvironmentStringsW

Frank Uhlig uhlig.frank at gmail.com
Fri Jan 24 16:05:28 CST 2020


OK, so I reproduced errors from Marvin's previous report before
submitting this particular patch using a mingw64 environment and
resolved them by adding a few forgotten null terminations.
However, Marvin tells me that the tests are still not working, yet I
don't see why. Might this be some issue related to double-null
termination? Any other issue between 32 and 64bit wine versions?

The one other thing I have tried beyond this, is running the GOG
Galaxy open beta and running some games in it, which is where this
function is used and it appears to work fine.

Again, any help appreciated, and have a nice weekend,

Frank

On Wed, Jan 22, 2020 at 11:48 PM Marvin <testbot at winehq.org> wrote:
>
> Hi,
>
> While running your changed tests, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
>
> Full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=63595
>
> Your paranoid android.
>
>
> === wxppro (32 bit report) ===
>
> kernel32:
> environ: Timeout
>
> === w2003std (32 bit report) ===
>
> kernel32:
> environ.c:623: Test failed: Setting environment strings failed
> environ.c:626: Test failed: Environment String settings resulted in different value
> environ.c:630: Test failed: Environment String settings resulted in different value
>
> === wvistau64 (32 bit report) ===
>
> kernel32:
> environ.c:623: Test failed: Setting environment strings failed
> environ.c:626: Test failed: Environment String settings resulted in different value
> environ.c:630: Test failed: Environment String settings resulted in different value
>
> === w2008s64 (32 bit report) ===
>
> kernel32:
> environ.c:623: Test failed: Setting environment strings failed
> environ.c:626: Test failed: Environment String settings resulted in different value
> environ.c:630: Test failed: Environment String settings resulted in different value
>
> === w7u (32 bit report) ===
>
> kernel32:
> environ.c:623: Test failed: Setting environment strings failed
> environ.c:626: Test failed: Environment String settings resulted in different value
> environ.c:630: Test failed: Environment String settings resulted in different value
>
> === w8 (32 bit report) ===
>
> kernel32:
> environ.c:623: Test failed: Setting environment strings failed
> environ.c:626: Test failed: Environment String settings resulted in different value
> environ.c:630: Test failed: Environment String settings resulted in different value
>
> === w8adm (32 bit report) ===
>
> kernel32:
> environ.c:623: Test failed: Setting environment strings failed
> environ.c:626: Test failed: Environment String settings resulted in different value
> environ.c:630: Test failed: Environment String settings resulted in different value
>
> === w864 (32 bit report) ===
>
> kernel32:
> environ.c:623: Test failed: Setting environment strings failed
> environ.c:626: Test failed: Environment String settings resulted in different value
> environ.c:630: Test failed: Environment String settings resulted in different value
>
> === w1064v1507 (32 bit report) ===
>
> kernel32:
> environ.c:623: Test failed: Setting environment strings failed
> environ.c:626: Test failed: Environment String settings resulted in different value
> environ.c:630: Test failed: Environment String settings resulted in different value
>
> === w1064v1809 (32 bit report) ===
>
> kernel32:
> environ.c:623: Test failed: Setting environment strings failed
> environ.c:626: Test failed: Environment String settings resulted in different value
> environ.c:630: Test failed: Environment String settings resulted in different value
>
> === w1064v1809_2scr (32 bit report) ===
>
> kernel32:
> environ.c:623: Test failed: Setting environment strings failed
> environ.c:626: Test failed: Environment String settings resulted in different value
> environ.c:630: Test failed: Environment String settings resulted in different value
>
> === w1064v1809_ar (32 bit report) ===
>
> kernel32:
> environ.c:623: Test failed: Setting environment strings failed
> environ.c:626: Test failed: Environment String settings resulted in different value
> environ.c:630: Test failed: Environment String settings resulted in different value
>
> === w1064v1809_he (32 bit report) ===
>
> kernel32:
> environ.c:623: Test failed: Setting environment strings failed
> environ.c:626: Test failed: Environment String settings resulted in different value
> environ.c:630: Test failed: Environment String settings resulted in different value
>
> === w1064v1809_ja (32 bit report) ===
>
> kernel32:
> environ.c:623: Test failed: Setting environment strings failed
> environ.c:626: Test failed: Environment String settings resulted in different value
> environ.c:630: Test failed: Environment String settings resulted in different value
>
> === w1064v1809_zh_CN (32 bit report) ===
>
> kernel32:
> environ.c:623: Test failed: Setting environment strings failed
> environ.c:626: Test failed: Environment String settings resulted in different value
> environ.c:630: Test failed: Environment String settings resulted in different value
>
> === wvistau64 (64 bit report) ===
>
> kernel32:
> environ.c:623: Test failed: Setting environment strings failed
> environ.c:626: Test failed: Environment String settings resulted in different value
> environ.c:630: Test failed: Environment String settings resulted in different value
>
> === w2008s64 (64 bit report) ===
>
> kernel32:
> environ.c:623: Test failed: Setting environment strings failed
> environ.c:626: Test failed: Environment String settings resulted in different value
> environ.c:630: Test failed: Environment String settings resulted in different value
>
> === w864 (64 bit report) ===
>
> kernel32:
> environ.c:623: Test failed: Setting environment strings failed
> environ.c:626: Test failed: Environment String settings resulted in different value
> environ.c:630: Test failed: Environment String settings resulted in different value
>
> === w1064v1507 (64 bit report) ===
>
> kernel32:
> environ.c:623: Test failed: Setting environment strings failed
> environ.c:626: Test failed: Environment String settings resulted in different value
> environ.c:630: Test failed: Environment String settings resulted in different value
>
> === w1064v1809 (64 bit report) ===
>
> kernel32:
> environ.c:623: Test failed: Setting environment strings failed
> environ.c:626: Test failed: Environment String settings resulted in different value
> environ.c:630: Test failed: Environment String settings resulted in different value
>
> === debian10 (32 bit report) ===
>
> kernel32:
> debugger.c:305: Test failed: GetThreadContext failed: 5
>
> === debian10 (32 bit Chinese:China report) ===
>
> kernel32:
> comm.c:918: Test failed: OutQueue should not be empty
> debugger.c:305: Test failed: GetThreadContext failed: 5
>
> === debian10 (64 bit WoW report) ===
>
> kernel32:
> comm.c:918: Test failed: OutQueue should not be empty
> debugger: Timeout



More information about the wine-devel mailing list