[PATCH 4/7] advapi32/tests: Fix spelling in a comment (codespell).

Henri Verbeet hverbeet at gmail.com
Mon Jan 27 05:59:52 CST 2020


On Sun, 26 Jan 2020 at 15:23, Sven Baars <sven.wine at gmail.com> wrote:
> On 26-01-2020 10:19, Mathew Hodson wrote:
> > Signed-off-by: Mathew Hodson <mathew.hodson at gmail.com>
> > ---
> >  dlls/advapi32/tests/service.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/dlls/advapi32/tests/service.c b/dlls/advapi32/tests/service.c
> > index 3872666..7ab7d8a 100644
> > --- a/dlls/advapi32/tests/service.c
> > +++ b/dlls/advapi32/tests/service.c
> > @@ -2472,7 +2472,7 @@ static void test_servicenotify(SC_HANDLE scm_handle, const char *servicename)
> >      ok(data.was_called == TRUE, "APC wasn't called\n");
> >      ok(data2.was_called == TRUE, "APC wasn't called\n");
> >
> > -    /* test cancelation: create notify on svc that will block until service
> > +    /* test cancellation: create notify on svc that will block until service
> >       * start; close svc; start service on svc2; verify that notification does
> >       * not happen */
> >
> >
>
> Both of these are correct actually in US spelling (cancelation being
> more recent), so this is not really an improvement.
>
It may not be enough of an improvement to change existing code, but as
a general principle I'd argue that Wine is an international project,
and it would be best to avoid US-specific spelling variants. I.e., if
this were new code, I'd prefer "cancellation" as well.



More information about the wine-devel mailing list