[PATCH 4/5] strmbase: Return S_FALSE from IEnumPins::Next() when the pin count changes.

Zebediah Figura z.figura12 at gmail.com
Tue Jan 28 23:36:54 CST 2020


Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
---
 dlls/quartz/tests/avisplit.c   | 1 -
 dlls/quartz/tests/filesource.c | 1 -
 dlls/quartz/tests/mpegsplit.c  | 1 -
 dlls/quartz/tests/waveparser.c | 1 -
 dlls/strmbase/filter.c         | 2 +-
 5 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/dlls/quartz/tests/avisplit.c b/dlls/quartz/tests/avisplit.c
index 31cb767b607..4af101767d6 100644
--- a/dlls/quartz/tests/avisplit.c
+++ b/dlls/quartz/tests/avisplit.c
@@ -353,7 +353,6 @@ static void test_enum_pins(void)
     graph = connect_input(filter, filename);
 
     hr = IEnumPins_Next(enum1, 1, pins, NULL);
-todo_wine
     ok(hr == S_FALSE, "Got hr %#x.\n", hr);
 
     hr = IEnumPins_Reset(enum1);
diff --git a/dlls/quartz/tests/filesource.c b/dlls/quartz/tests/filesource.c
index 3e571fa0e33..918605da6d4 100644
--- a/dlls/quartz/tests/filesource.c
+++ b/dlls/quartz/tests/filesource.c
@@ -526,7 +526,6 @@ static void test_enum_pins(void)
     load_file(filter, filename);
 
     hr = IEnumPins_Next(enum1, 1, pins, NULL);
-todo_wine
     ok(hr == S_FALSE, "Got hr %#x.\n", hr);
 
     hr = IEnumPins_Reset(enum1);
diff --git a/dlls/quartz/tests/mpegsplit.c b/dlls/quartz/tests/mpegsplit.c
index c45f982a027..67dd6d312dc 100644
--- a/dlls/quartz/tests/mpegsplit.c
+++ b/dlls/quartz/tests/mpegsplit.c
@@ -347,7 +347,6 @@ static void test_enum_pins(void)
     graph = connect_input(filter, filename);
 
     hr = IEnumPins_Next(enum1, 1, pins, NULL);
-todo_wine
     ok(hr == S_FALSE, "Got hr %#x.\n", hr);
 
     hr = IEnumPins_Reset(enum1);
diff --git a/dlls/quartz/tests/waveparser.c b/dlls/quartz/tests/waveparser.c
index 61ba2018e4e..e9540bc0f55 100644
--- a/dlls/quartz/tests/waveparser.c
+++ b/dlls/quartz/tests/waveparser.c
@@ -351,7 +351,6 @@ static void test_enum_pins(void)
     graph = connect_input(filter, filename);
 
     hr = IEnumPins_Next(enum1, 1, pins, NULL);
-todo_wine
     ok(hr == S_FALSE, "Got hr %#x.\n", hr);
 
     hr = IEnumPins_Reset(enum1);
diff --git a/dlls/strmbase/filter.c b/dlls/strmbase/filter.c
index a7e5fcd3f04..43da4b3fb90 100644
--- a/dlls/strmbase/filter.c
+++ b/dlls/strmbase/filter.c
@@ -122,7 +122,7 @@ static HRESULT WINAPI enum_pins_Next(IEnumPins *iface, ULONG count, IPin **pins,
         *ret_count = 0;
 
     if (enum_pins->version != enum_pins->filter->pin_version)
-        return VFW_E_ENUM_OUT_OF_SYNC;
+        return S_FALSE;
 
     for (i = 0; i < count; ++i)
     {
-- 
2.25.0




More information about the wine-devel mailing list