[PATCH] winegstreamer: Append a deinterlace element to the video post-processing chain.
Zebediah Figura
z.figura12 at gmail.com
Wed Jul 1 12:10:01 CDT 2020
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=30366
Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
---
dlls/winegstreamer/gstdemux.c | 21 +++++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c
index 5697d2c0e0c..e6f00842df5 100644
--- a/dlls/winegstreamer/gstdemux.c
+++ b/dlls/winegstreamer/gstdemux.c
@@ -995,7 +995,16 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, struct gstdemux *
if (!strcmp(typename, "video/x-raw"))
{
- GstElement *vconv, *flip;
+ GstElement *vconv, *flip, *deinterlace;
+
+ /* DirectShow can express interlaced video, but downstream filters can't
+ * necessarily consume it. In particular, the video renderer can't. */
+ if (!(deinterlace = gst_element_factory_make("deinterlace", NULL)))
+ {
+ ERR("Failed to create deinterlace, are %u-bit GStreamer \"base\" plugins installed?\n",
+ 8 * (int)sizeof(void *));
+ goto out;
+ }
/* decodebin considers many YUV formats to be "raw", but some quartz
* filters can't handle those. Also, videoflip can't handle all "raw"
@@ -1018,14 +1027,18 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, struct gstdemux *
goto out;
}
- gst_bin_add(GST_BIN(This->container), vconv); /* bin takes ownership */
+ /* The bin takes ownership of these elements. */
+ gst_bin_add(GST_BIN(This->container), deinterlace);
+ gst_element_sync_state_with_parent(deinterlace);
+ gst_bin_add(GST_BIN(This->container), vconv);
gst_element_sync_state_with_parent(vconv);
- gst_bin_add(GST_BIN(This->container), flip); /* bin takes ownership */
+ gst_bin_add(GST_BIN(This->container), flip);
gst_element_sync_state_with_parent(flip);
+ gst_element_link(deinterlace, vconv);
gst_element_link(vconv, flip);
- pin->post_sink = gst_element_get_static_pad(vconv, "sink");
+ pin->post_sink = gst_element_get_static_pad(deinterlace, "sink");
pin->post_src = gst_element_get_static_pad(flip, "src");
pin->flip = flip;
}
--
2.27.0
More information about the wine-devel
mailing list