[PATCH] user32/tests: Fix test that has been successful.

Jiajin Cui cuijiajin at uniontech.com
Wed Jul 1 22:18:17 CDT 2020


Hi Zhiyi,
    Thank you for your reply, I was revising other issues that were found in the testbot verification, which seemed to be only good at the time.
>
>
>On 7/2/20 10:15 AM, Jiajin Cui wrote:
>>
>> 0001-user32-tests-Fix-test-that-has-been-successful.patch
>>
>> From 5c3930407ac0e313121d56f760e4ad998f233e65 Mon Sep 17 00:00:00 2001
>> From: Jiajin Cui <cuijiajin at uniontech.com>
>> Date: Thu, 2 Jul 2020 09:59:46 +0800
>> Subject: [PATCH] user32/tests: Fix test that has been successful.
>>
>> Someone has fixed the issue of the ShowWindow parameter as SW_MINIMIZE, but no fix to the test code.
>>
>> Signed-off-by: Jiajin Cui <cuijiajin at uniontech.com>
>> ---
>>  dlls/user32/tests/msg.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
>> index f84525a0bf..51091e3408 100644
>> --- a/dlls/user32/tests/msg.c
>> +++ b/dlls/user32/tests/msg.c
>> @@ -5186,7 +5186,7 @@ static void test_messages(void)
>> 
>>      ShowWindow(hwnd, SW_MINIMIZE);
>>      flush_events();
>> -    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", TRUE);
>> +    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", FALSE);
>>      flush_sequence();
>> 
>>      if (GetWindowLongW( hwnd, GWL_STYLE ) & WS_MINIMIZE)
>See https://www.winehq.org/pipermail/wine-devel/2019-May/146430.html
>It is not fixed on FVWM, which is the window manager that TestBots use.


More information about the wine-devel mailing list