[PATCH 2/2] amstream/tests: Fix filter leak in test_add_stream().

[Zebediah Figura]

On 7/6/20 5:58 PM, Gijs Vermeulen wrote:
> Signed-off-by: Gijs Vermeulen <gijsvrm at gmail.com>
> ---
>  dlls/amstream/tests/amstream.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/dlls/amstream/tests/amstream.c b/dlls/amstream/tests/amstream.c
> index 0e9c40d118..055661e8be 100644
> --- a/dlls/amstream/tests/amstream.c
> +++ b/dlls/amstream/tests/amstream.c
> @@ -894,8 +894,6 @@ static void test_add_stream(void)
>          hr = IAMMultiMediaStream_GetFilterGraph(mmstream, &graph);
>          ok(hr == S_OK, "Got hr %#x.\n", hr);
>          ok(!!graph, "Got graph %p.\n", graph);
> -        hr = IAMMultiMediaStream_GetFilter(mmstream, &stream_filter);
> -        ok(hr == S_OK, "Got hr %#x.\n", hr);
>          hr = IGraphBuilder_EnumFilters(graph, &enum_filters);
>          ok(hr == S_OK, "Got hr %#x.\n", hr);
>          hr = IEnumFilters_Next(enum_filters, 3, filters, &count);
> @@ -906,8 +904,7 @@ static void test_add_stream(void)
>          hr = IBaseFilter_GetClassID(filters[0], &clsid);
>          ok(hr == S_OK, "Got hr %#x.\n", hr);
>          ok(IsEqualGUID(&clsid, &CLSID_DSoundRender), "Got unexpected filter %s.\n", wine_dbgstr_guid(&clsid));
> -        IBaseFilter_Release(filters[0]);

Did you mean to remove this line?

> -        IMediaStreamFilter_Release(stream_filter);
> +        IBaseFilter_Release(filters[1]);
>          IEnumFilters_Release(enum_filters);
>          IGraphBuilder_Release(graph);
>      }
> @@ -919,9 +916,10 @@ static void test_add_stream(void)
>              AMMSF_ADDDEFAULTRENDERER, &audio_stream);
>      ok(hr == E_INVALIDARG, "Got hr %#x.\n", hr);
>  
> -    IMediaStreamFilter_Release(stream_filter);
>      ref = IAMMultiMediaStream_Release(mmstream);
>      ok(!ref, "Got outstanding refcount %d.\n", ref);
> +    ref = IMediaStreamFilter_Release(stream_filter);
> +    ok(!ref, "Got outstanding refcount %d.\n", ref);
>  }
>  
>  static void test_media_streams(void)
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200707/7532ca66/attachment.sig>