[PATCH v2 01/11] kernel32/tests: Add more invalid handle tests.

Zebediah Figura z.figura12 at gmail.com
Thu Jul 9 12:47:04 CDT 2020


Hello Jacek,

On 7/9/20 12:27 PM, Jacek Caban wrote:
> Signed-off-by: Jacek Caban <jacek at codeweavers.com>
> ---
> v2: Don't depend on ioctl to set proper last error, it should fix
> failures on TestBot. The first patch demonstrates the problem without
> depending on the way tests are launched.
> 
>  dlls/kernel32/tests/console.c | 63 +++++++++++++++++++++++++++++++++++
>  1 file changed, 63 insertions(+)
> 
> 

I probably should have mentioned this earlier, but in truth it took
until noticing this patch series to remember.

In bug 46635 an application passes standard handles to NtQueryObject(),
expecting it to return failure if the handle is a console handle. This
leads me to believe that console handles should not be NT kernel handles
at all, which means that this patch series' approach to checking invalid
handles may not be quite correct. Possibly instead we should use a local
table...?

ἔρρωσο,
Zeb

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200709/4e20e5df/attachment.sig>


More information about the wine-devel mailing list