[PATCH 4/5] wined3d: Update reported NVIDIA driver version for Fermi+ GPUs.

Henri Verbeet hverbeet at gmail.com
Mon Jul 13 08:09:03 CDT 2020


On Mon, 13 Jul 2020 at 16:32, Matteo Bruni <mbruni at codeweavers.com> wrote:
> @@ -853,7 +855,7 @@ void wined3d_driver_info_init(struct wined3d_driver_info *driver_info,
>                  driver_info->vendor, driver_info->device, driver_model);
>          driver_info->name = "Display";
>          driver_info->version_high = MAKEDWORD_VERSION(driver_os_version, driver_feature_level);
> -        driver_info->version_low = MAKEDWORD_VERSION(8, 6); /* NVIDIA RIVA TNT, arbitrary */
> +        driver_info->version_low = MAKEDWORD_VERSION(14, 4587); /* NVIDIA Kepler, arbitrary */
>      }
Did that really need updating? Replacing one arbitrary number with
another arbitrary number seems arbitrary. And, the reason that number
is arbitrary in the first place is that it's on an ERR path. The
correct thing to do would probably be to return an error, and fail
adapter creation.



More information about the wine-devel mailing list