[PATCH 5/5] devenum: Call DMOGetTypes() until less types are returned than were allocated.
Zebediah Figura
z.figura12 at gmail.com
Mon Jul 13 09:38:05 CDT 2020
Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
---
Congratulations, Microsoft, on this well-designed API.
dlls/devenum/mediacatenum.c | 25 ++++++++++++-------------
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/dlls/devenum/mediacatenum.c b/dlls/devenum/mediacatenum.c
index 16b729ab1fd..ab675b5656f 100644
--- a/dlls/devenum/mediacatenum.c
+++ b/dlls/devenum/mediacatenum.c
@@ -147,28 +147,27 @@ static HRESULT WINAPI property_bag_Read(IPropertyBag *iface,
};
unsigned int count = 1, input_count, output_count, i;
- DMO_PARTIAL_MEDIATYPE *types = NULL;
+ DMO_PARTIAL_MEDIATYPE *types = NULL, *new_array;
REGPINTYPES *reg_types;
HRESULT hr;
- if (!(types = malloc(2 * count * sizeof(*types))))
- return E_OUTOFMEMORY;
-
- while ((hr = DMOGetTypes(&moniker->clsid, count, &input_count, types,
- count, &output_count, types + count)) == S_FALSE)
+ do
{
count *= 2;
- if (!(types = realloc(types, count * sizeof(*types))))
+ if (!(new_array = realloc(types, 2 * count * sizeof(*types))))
{
free(types);
return E_OUTOFMEMORY;
}
- }
- if (hr != S_OK)
- {
- free(types);
- return hr;
- }
+ types = new_array;
+
+ if (FAILED(hr = DMOGetTypes(&moniker->clsid, count, &input_count, types,
+ count, &output_count, types + count)))
+ {
+ free(types);
+ return hr;
+ }
+ } while (input_count == count || output_count == count);
if (!(reg_types = malloc(2 * count * sizeof(*reg_types))))
{
--
2.27.0
More information about the wine-devel
mailing list