[PATCH v2] ws2_32: Drop dependencies on system getprotoby(name|number) functions

[Alex Henrie]

On Tue, Jul 14, 2020 at 10:25 AM Alexandre Julliard <julliard at winehq.org> wrote:
>
> Alex Henrie <alexhenrie24 at gmail.com> writes:
>
> >  On Tue, Jul 14, 2020 at 9:41 AM Zebediah Figura <z.figura12 at gmail.com> wrote:
> >>
> >> > +    /* keep this list sorted by number for binary search */
> >>
> >> This seems to me like it should be a separate patch.
> >
> > Why? I have to change the implementation of getprotobynumber anyway,
> > and I don't want to cause a performance regression, so it seems that I
> > might as well put in the binary search at the same time.
> >
> > [...]
> >
> > It's meant to mirror the format of the other ok statements in
> > test_getprotobyname and test_getprotobynumber. But it's just a style
> > thing; I'll delete the line break here if more people say that they
> > don't like it.
>
> In these cases and in general, please accept criticism and make the
> requested changes, without requesting input from more people. If someone
> reviewed your patch and told you that some things need changing, it's
> safe to assume that you should make the changes and resubmit.

Hi Alexandre, thank you for joining the discussion :-) I am happy to
make these two changes.

I think I should mention that it's hard for me to not feel a little
picked on in situations like this. If the situation were reversed and
it were me giving my opinion on Zeb's code style, would the same
advice apply to him?

-Alex