[PATCH v4 1/3] windowscodecs: Implement DdsDecoder_Wine_Initialize().

Ziqing Hui zhui at codeweavers.com
Tue Jul 14 22:18:03 CDT 2020


It breaks loading cube map in D3DX10GetImageInfoFromMemory().

I think a solution is using DdsDecoder_Wine_Initialize() in windowscodecs/imgfactory.c: find_decoder() if DdsDecoder_Initialize() fails, like:

    hr = DdsDecoder_Initialize();
    if (FAILED(hr)) {
        DdsDecoder_Wine_Initialize();
    }

(d3dx10 uses CreateDecoderFromStream() to create a decoder, CreateDecoderFromStream() invokes find_decoder())

I was planning to add these code in a future patch. Now we can add it in this patch. What do you think?

On 7/15/20 9:41 AM, Esme Povirk (they/them) wrote:
> tionality in d3dx10 that previously worked?
>
> My suggestion would be to move the code to DdsDecoder_Wine_Initialize,
> update d3dx10 to use this interface if available, then update the
> validation in DdsDecoder_In
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200715/4e32cdf1/attachment.htm>


More information about the wine-devel mailing list