[PATCH 1/5] winevulkan: Move vkGetPhysicalDeviceSurfacePresentModesKHR to a private thunk

Liam Middlebrook lmiddlebrook at nvidia.com
Thu Jul 16 15:12:19 CDT 2020

I don't think this is necessary. See Brendan's comment on patch 5/5.

Also for what it's worth, I think it would have been fine to have this 
and patch 2/5 combined into one change, maybe even patch 3/5 also, since 
you're just doing preparatory work for patch 5/5.

Also, while it's not really enforced strongly (at least for winevulkan 
patched) it's generally preferable to leave generated changes out of the 
patches. For the small stuff like this, it's fine, it's just more 
cumbersome for larger changes where new 
enums/extensions/functions/structs are being added.


Liam Middlebrook

On 7/16/20 12:41 AM, Joshua Ashton wrote:

More information about the wine-devel mailing list