[PATCH 3/5] dsdmo/tests: Add tests for aggregation.
Andrew Eikum
aeikum at codeweavers.com
Thu Jul 23 11:40:56 CDT 2020
On Thu, Jul 23, 2020 at 11:38:04AM -0500, Zebediah Figura wrote:
> On 7/23/20 10:21 AM, Andrew Eikum wrote:
> > On Tue, Jul 21, 2020 at 06:16:52PM -0500, Zebediah Figura wrote:
> >> Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
> >> ---
> >> dlls/dsdmo/tests/Makefile.in | 5 ++
> >> dlls/dsdmo/tests/dsdmo.c | 162 +++++++++++++++++++++++++++++++++++
> >> 2 files changed, 167 insertions(+)
> >
> > This needs a configure.ac change, right? That might be why the testbot
> > failed. FWIW with that change, it passes on my machine and the
> > testbot:
> >
> > https://testbot.winehq.org/JobDetails.pl?Key=75977
>
> Yes, I usually omit them because Alexandre reruns it anyway (and my
> local version has never quite matched). The testbot should be able to
> figure out that it needs to rerun make_makefiles, but the logic may be
> broken...
>
My understanding was you should include the configure.ac changes,
since that file isn't generated, but not the configure/config.h.in/etc
changes, because those are generated.
Andrew
More information about the wine-devel
mailing list