[PATCH v2 1/3] ddraw/tests: Test non-primary surface in test_lost_device.

Stefan Dösinger stefandoesinger at gmail.com
Mon Jul 27 11:30:13 CDT 2020

> Am 27.07.2020 um 19:05 schrieb Gabriel Ivăncescu <gabrielopcode at gmail.com>:
> +    surface_desc.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT | DDSD_PIXELFORMAT;
> +    surface_desc.ddsCaps.dwCaps = DDSCAPS_OFFSCREENPLAIN;

This will either create a video or system memory surface depending on the whims of the driver. Since we already explicitly test offscreen sysmem surfaces, shouldn't this one request video memory explicitly and skip some tests if creation fails? That might make your broken(hr == DD_OK) /* WinXP */ go away.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200727/8e996693/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200727/8e996693/attachment.sig>

More information about the wine-devel mailing list