[PATCH v2 1/3] ddraw/tests: Test non-primary surface in test_lost_device.

Henri Verbeet hverbeet at gmail.com
Tue Jul 28 05:37:17 CDT 2020

On Mon, 27 Jul 2020 at 22:06, Gabriel Ivăncescu <gabrielopcode at gmail.com> wrote:
> On 27/07/2020 19:30, Stefan Dösinger wrote:
> > This will either create a video or system memory surface depending on
> > the whims of the driver. Since we already explicitly test offscreen
> > sysmem surfaces, shouldn't this one request video memory explicitly and
> > skip some tests if creation fails? That might make your broken(hr ==
> > DD_OK) /* WinXP */ go away.
> >
> You're right, sorry, I'm not very familiar with ddraw. I tried with
> DDSCAPS_VIDEOMEMORY (and even DDSCAPS_LOCALVIDMEM, though it shouldn't
> be necessary), unfortunately it's still broken on Windows XP so that
> broken check has to stay.
Why do you consider the Windows XP result broken? DD_OK is what I
would expect for DDSCL_NORMAL.

More information about the wine-devel mailing list