[PATCH v3 2/3] amstream: Implement IAMMultiMediaStream::GetDuration.

[Zebediah Figura]

On 7/28/20 3:53 AM, Myah Caron wrote:
>> It seems, given the tests below, that S_FALSE is returned if the graph
>> can't seek (i.e. it's translated from E_NOTIMPL). In that case it'd be
>> better to key this return value on the return from AddMediaStream() above.
> 
> Thanks for the review.
> 
> Sorry if I'm misunderstanding you, but I'm pretty sure the earlier AddMediaStream calls succeed under windows server. I believe the issue is that decoding AVI files isn't supported under windows server (I read something to that effect a few days ago, though for some reason I'm unable to find the link now).

We render and seek an AVI file (which admittedly is video-only) in
quartz:filtergraph, apparently successfully:

http://test.winehq.org/data/a22b295cc30d89e446038c4e677f8ea6fef159e1/2008_newtb-w2008s64-32/quartz:filtergraph.html

I'd expect OpenFile() to fail if the file can't be rendered.

On the other hand, w2008s uniquely lacks audio hardware, so I would
indeed expect VFW_E_NO_AUDIO_HARDWARE when adding the default audio
renderer.

> 
> Would adding an extra test (like IAMMultiMediaStream_GetInformation) to see if AVI files can be seeked be alright?
> 
>> Also, a bit of a nitpick, but I think that duration would be more
>> readable in decimal.
> 
> Good point, will fix.
> 
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200728/a847c81a/attachment-0001.sig>