[PATCH 2/7] ieframe: Implement IOleObject::Advise().

Dmitry Timoshkov dmitry at baikal.ru
Tue Jul 28 10:51:40 CDT 2020

Hi Jacek,

Jacek Caban <jacek at codeweavers.com> wrote:

> Please add some test cases. For this series, at least some basic calls 
> should be easy to test. However, are those callbacks supposed to be 
> called? If yes, then this is rather a "semi-stub" implementation and 
> would be good to mark it as such. Ideally, we'd have the object advised 
> in something like test_WebBrowser to see if/how are those callbacks used.

These patches implement appropriate methods similar to what ole32/defaulthandler.c
and mshtml do, and in that regard these implementations are not semi-stubs
but rather pretty complete. What is missing - is actual notifications of
the sink about particular events, and that's where the tests could be
helpful. I'll certainly look at the WebBrowser tests and see what kind
of notifications and at which events they are supposed to get, however
I hope that the patches could be accepted as is, without the tests since
they follow existing ole32/defaulthandler.c and mshtml implementations.


More information about the wine-devel mailing list