[PATCH v2 1/2] amstream: Increase parent IAMMediaStream refcount in IAudioMediaStream::CreateSample().
Gijs Vermeulen
gijsvrm at gmail.com
Wed Jul 29 07:43:59 CDT 2020
Signed-off-by: Gijs Vermeulen <gijsvrm at gmail.com>
---
dlls/amstream/audiostream.c | 2 ++
dlls/amstream/tests/amstream.c | 3 +++
2 files changed, 5 insertions(+)
diff --git a/dlls/amstream/audiostream.c b/dlls/amstream/audiostream.c
index 112891eeb7..e888caaa98 100644
--- a/dlls/amstream/audiostream.c
+++ b/dlls/amstream/audiostream.c
@@ -201,6 +201,7 @@ static ULONG WINAPI IAudioStreamSampleImpl_Release(IAudioStreamSample *iface)
if (!ref)
{
+ IAMMediaStream_Release(&This->parent->IAMMediaStream_iface);
CloseHandle(This->update_event);
HeapFree(GetProcessHeap(), 0, This);
}
@@ -375,6 +376,7 @@ static HRESULT audiostreamsample_create(struct audio_stream *parent, IAudioData
object->IAudioStreamSample_iface.lpVtbl = &AudioStreamSample_Vtbl;
object->ref = 1;
object->parent = parent;
+ IAMMediaStream_AddRef(&parent->IAMMediaStream_iface);
object->audio_data = audio_data;
object->update_event = CreateEventW(NULL, FALSE, FALSE, NULL);
diff --git a/dlls/amstream/tests/amstream.c b/dlls/amstream/tests/amstream.c
index 68d2b9c18f..17f00dcdf9 100644
--- a/dlls/amstream/tests/amstream.c
+++ b/dlls/amstream/tests/amstream.c
@@ -1421,8 +1421,11 @@ static void test_media_streams(void)
hr = IAudioMediaStream_CreateSample(audio_media_stream, NULL, 0, &audio_sample);
ok(hr == E_POINTER, "IAudioMediaStream_CreateSample returned: %x\n", hr);
+
+ EXPECT_REF(audio_stream, 3);
hr = IAudioMediaStream_CreateSample(audio_media_stream, audio_data, 0, &audio_sample);
ok(hr == S_OK, "IAudioMediaStream_CreateSample returned: %x\n", hr);
+ EXPECT_REF(audio_stream, 4);
hr = IAudioMediaStream_GetMultiMediaStream(audio_media_stream, NULL);
ok(hr == E_POINTER, "Expected E_POINTER, got %x\n", hr);
--
2.27.0
More information about the wine-devel
mailing list