[PATCH V2] winspool.drv: Implement AddPrintProcessorA via AddPrintProcessorW
Dmitry Timoshkov
dmitry at baikal.ru
Mon Jun 1 04:06:26 CDT 2020
Vijay Kiran Kamuju <infyquest at gmail.com> wrote:
> + TRACE("(%s,%s,%s,%s): stub\n", debugstr_a(pName), debugstr_a(pEnvironment),
> debugstr_a(pPathName), debugstr_a(pPrintProcessorName));
": stub" doesn't belong to a TRACE.
> + RtlFreeUnicodeString(&ProcessorW);
> + RtlFreeUnicodeString(&PathW);
> + RtlFreeUnicodeString(&EnvW);
> + RtlFreeUnicodeString(&NameW);
This could be a simple HeapFree, have a look at other places that use
asciitounicode(). I have to admit, that asciitounicode() is an over-
engineering, and could be replaced by simple strdupAtoW() in most (if
not all) places.
--
Dmitry.
More information about the wine-devel
mailing list