[PATCH] joy.cpl: Fix pulsing buttons in joystick button state display.

Torge Matthies openglfreak at googlemail.com
Fri Jun 5 11:37:30 CDT 2020


Signed-off-by: Torge Matthies <openglfreak at googlemail.com>
---
Bug encountered by junaru on the VKx Discord.

 dlls/joy.cpl/main.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/dlls/joy.cpl/main.c b/dlls/joy.cpl/main.c
index 4ad9cf848c..3921f59cbb 100644
--- a/dlls/joy.cpl/main.c
+++ b/dlls/joy.cpl/main.c
@@ -404,8 +404,7 @@ static DWORD WINAPI input_thread(void *param)
 
         /* Indicate pressed buttons */
         for (i = 0; i < data->joysticks[data->chosen_joystick].num_buttons; i++)
-            if (state.rgbButtons[i])
-                SendMessageW(data->graphics.buttons[i], BM_SETSTATE, TRUE, 0);
+            SendMessageW(data->graphics.buttons[i], BM_SETSTATE, !!state.rgbButtons[i], 0);
 
         /* Indicate axis positions, axes showing are hardcoded for now */
         axes_pos[0][0] = state.lX;
@@ -438,10 +437,6 @@ static DWORD WINAPI input_thread(void *param)
         }
 
         Sleep(TEST_POLL_TIME);
-
-        /* Reset button state */
-        for (i = 0; i < data->joysticks[data->chosen_joystick].num_buttons; i++)
-            SendMessageW(data->graphics.buttons[i], BM_SETSTATE, FALSE, 0);
     }
 
     return 0;
-- 
2.27.0




More information about the wine-devel mailing list