[PATCH 1/2] setupapi/tests: Add error tests for SetupDiDestroyDeviceInfoList.

Jeff Smith whydoubt at gmail.com
Sun Jun 7 00:49:23 CDT 2020


On Sat, Jun 6, 2020, 11:58 PM Dmitry Timoshkov <dmitry at baikal.ru> wrote:

> Zebediah Figura <z.figura12 at gmail.com> wrote:
>
> > On 6/6/20 11:45 PM, Dmitry Timoshkov wrote:
> > > Jeff Smith <whydoubt at gmail.com> wrote:
> > >
> > >> +    SetLastError(0xcafef00d);
> > >
> > > Please use a commonly accepted value of 0xdeadbeef.
> >
> > Is this really worthwhile? It's pretty obvious that both are sentinel
> > values.
>
> It's just one of common practices in Wine tests, IMO it would be nice to
> use an existing one instead of inventing new all other the place.


As deadbeef is also retuned by class_error and co_error, I intentionally
chose a different value so that it would possible to determine the true
source of the value.  What solution do you recommend?

Thanks,
Jeff
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200607/2588f83a/attachment.htm>


More information about the wine-devel mailing list