[PATCH 2/3] windowscodecs: Initialize block data in DdsDecoder_Dds_GetFrame().
Ziqing Hui
zhui at codeweavers.com
Mon Jun 8 00:09:15 CDT 2020
Yeah, you are correct. I'll fix it in next version.
On 6/5/20 11:50 PM, Esme Povirk (they/them) wrote:
> + if (ref == 0) {
> + HeapFree(GetProcessHeap(), 0, This);
> + HeapFree(GetProcessHeap(), 0, This->data);
> + }
>
> This is dereferencing a pointer after it's been freed.
>
> The loop in GetFrame seems unnecessarily complicated. If the size of
> each item in the array is the same, we don't really need to calculate
> it for each one, do we?
More information about the wine-devel
mailing list