[PATCH] crypt32: Store CRYPT_KEY_PROV_INFO in a platform independent way.
Dmitry Timoshkov
dmitry at baikal.ru
Mon Jun 8 21:22:34 CDT 2020
Alexandre Julliard <julliard at winehq.org> wrote:
> >> This makes reading and writing of CRYPT_KEY_PROV_INFO certificate property
> >> from/to the certificate storage independent from architecture the crypt32.dll
> >> code being executed on.
> >
> > Is there anything that could be improved to make this patch accepted?
>
> That data structure looks strange. Maybe you could explain why it needs
> to use the 64-bit layout, and why you are achieving that with padding
> instead of using 64-bit types?
64-bit layout is used so that 64-bit crypt32 is able to read the structure
saved by 32-bit crypt32, currently this leads to a memory corruption. There's
no reason to not use 64-bit types, thanks.
--
Dmitry.
More information about the wine-devel
mailing list