[PATCH 1/4] oleaut32: Fix TypeLibCount for SLTG_OtherTypeInfo
Huw Davies
huw at codeweavers.com
Thu Jun 11 08:29:32 CDT 2020
On Thu, Jun 11, 2020 at 02:22:16PM +0200, Vijay Kiran Kamuju wrote:
> On Thu, Jun 11, 2020 at 2:00 PM Huw Davies <huw at codeweavers.com> wrote:
> > It's more complicated than that. ->TypeInfoCount is set earlier on,
> > should that be changed to a local variable or something?
> Yes, I think that this complicates complete constructor implementation.
> As the TypeInfoCount is used in a lot of places.
> I have to test by moving to a local variable, I believe this may lead
> to crashes.
The issue is that it would now be initialised in two places. Which
one is correct?
> > Also, there are still bits on [2/4] that aren't do to with help
> > strings, e.g. the small_no and typekind change, and all the offset
> > renumbering.
> Should I send the patch for small_no, typekind change first, which
> also affects the offset renumbering.
Yes, though I rather suspect this is linked to the TypeInfoCount issue,
so you'll need to understand that first.
Huw.
More information about the wine-devel
mailing list