[PATCH] winhttp: Support WINHTTP_OPTION_UPGRADE_TO_WEB_SOCKET option

[Alistair Leslie-Hughes]

Hi Hans,

Thanks for the review.

On 12/6/20 5:15 pm, Hans Leidekker wrote:
> On Fri, 2020-06-12 at 16:32 +1000, Alistair Leslie-Hughes wrote:
>> diff --git a/dlls/winhttp/session.c b/dlls/winhttp/session.c
>> index 24455d858a6..105e292b15d 100644
>> --- a/dlls/winhttp/session.c
>> +++ b/dlls/winhttp/session.c
                              WINHTTP_ADDREQ_FLAG_ADD | 
WINHTTP_ADDREQ_FLAG_REPLACE);
> 
> Can you add a test to show that headers are set here? A simple
> websocket echo test would be nice too. And please check
> add_request_headers for failure.

I started writing a test, which forced the key to specific value, 
however the returned key failed to validate and is causing a test 
failure.  So, my guess that since it cannot be manually set, these are 
added during WinHttpSendRequest if the option has been set.

We might need to store the string for validation in 
WinHttpWebSocketCompleteUpgrade.

I'll update the patch to reflect this.

Regards
Alistair.