[PATCH 1/2] oleaut32: Add guid to SLTG_Header

[Vijay Kiran Kamuju]

On Fri, Jun 12, 2020 at 11:19 AM Huw Davies <huw at codeweavers.com> wrote:
>
> On Thu, Jun 11, 2020 at 08:06:07PM +0200, Vijay Kiran Kamuju wrote:
> > Signed-off-by: Vijay Kiran Kamuju <infyquest at gmail.com>
>
> > From 992141cf21eec6058a7a09437daba2acf7555f08 Mon Sep 17 00:00:00 2001
> > From: Vijay Kiran Kamuju <infyquest at gmail.com>
> > Date: Thu, 11 Jun 2020 17:49:32 +0200
> > Subject: [PATCH 1/2] oleaut32: Add guid to SLTG_Header
> >
> > Signed-off-by: Vijay Kiran Kamuju <infyquest at gmail.com>
> > ---
> >  dlls/oleaut32/typelib.h | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/dlls/oleaut32/typelib.h b/dlls/oleaut32/typelib.h
> > index 9c700b11a7..521d176bfe 100644
> > --- a/dlls/oleaut32/typelib.h
> > +++ b/dlls/oleaut32/typelib.h
> > @@ -309,10 +309,7 @@ typedef struct {
> >  /*08*/  WORD res08;             /* some kind of len/offset ?? */
> >  /*0a*/       WORD first_blk;         /* 1 based index into blk entries that
> >                                  corresponds to first block in file */
> > -/*0c*/       DWORD res0c;            /* always 0x000204ff */
> > -/*10*/  DWORD res10;         /* always 0x00000000 */
> > -/*14*/       DWORD res14;            /* always 0x000000c0 */
> > -/*18*/       DWORD res18;            /* always 0x46000000 */
> > +/*0c*/       GUID guid;              /* always 000204ff-0000-0000-c000-000000000046 */
> >  /*1c*/       DWORD res1c;            /* always 0x00000044 */
> >  /*20*/       DWORD res20;            /* always 0xffff0000 */
> >  } SLTG_Header;
>
> Makes sense, thanks.  Looking again I suspect that the two DWORDs
> after this are actually the first SLTG_BlkEntry (although appearing
> last in the linked list)---this would explain the apparent off-by-one
> of noOfFileBlks.
>
I also believe that res1c is not always 0x00000044. If you check the
sample tlb I attached to #49372
(https://bugs.winehq.org/show_bug.cgi?id=49372), you will find that it
is 0x00000034.
Yes, the above would explain the off by 1 in noOfFileBlks - this must
be first SLTG_BlkEntry.
> I've sent in new versions with reworded commit messages.
>
Thanks a lot.
> Thanks,
> Huw.
Vijay