[PATCH 1/4] d3dx9: Use BitScanReverse in make_pow2.

Jacek Caban jacek at codeweavers.com
Fri Jun 12 07:32:53 CDT 2020


On 11.06.2020 22:13, Matteo Bruni wrote:
> On Wed, Jun 10, 2020 at 2:21 PM Jacek Caban <jacek at codeweavers.com> wrote:
>> Signed-off-by: Jacek Caban <jacek at codeweavers.com>
>> ---
>> I left behaviour for num == 1 unchanged, but according to the comment it
>> should be 0. We don't seem to have a test for that.
> You mean for num == 0? That's sort of an invalid value, it shouldn't
> matter (and returning 1 for that seems safer anyway).


Oh, right, that comment was messed up.


Thanks for the review,

Jacek




More information about the wine-devel mailing list