[PATCH v2] winegstreamer: Prevent hanging when loading a short MP3 file.

Akihiro Sagawa sagawa.aki at gmail.com
Sat Jun 13 00:58:40 CDT 2020


In v2, fix the test failures in test_media_types(), quartz:mpegcplit.
Zebediah, thanks for the review and inspecting quartz:filtergraph test
failures.
---
If Info tag[1] isn't present in the MP3 file, GStreamer trys to read
some more frames from the file to estimate a duration. Then, it sends
a duration-changed message to winegstreamer.
However, it seems not to send the message if the file is too short to
estimate the duration, e.g. 0.5 seconds. Winegstreamer gets stuck in
this case.

This patch removes Info tag from dlls/quartz/tests/test.mp3 and fixes
the above issue by watching pad's EOS events.

[1] http://gabriel.mp3-tech.org/mp3infotag.html

Signed-off-by: Akihiro Sagawa <sagawa.aki at gmail.com>
---
 dlls/quartz/tests/mpegsplit.c |   8 ++++----
 dlls/quartz/tests/rsrc.rc     |   2 +-
 dlls/quartz/tests/test.mp3    | Bin 2349 -> 2157 bytes
 dlls/winegstreamer/gstdemux.c |  13 ++++++++++---
 4 files changed, 15 insertions(+), 8 deletions(-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: v2-0001-winegstreamer-Prevent-hanging-when-loading-a-shor.patch
Type: text/x-patch
Size: 9138 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200613/91bd8061/attachment.bin>


More information about the wine-devel mailing list