[PATCH 3/7] winevulkan: Change blacklist to a more neutral word

Liam Middlebrook lmiddlebrook at nvidia.com
Tue Jun 16 21:44:19 CDT 2020


Would you mind changing it to "unsupported" instead of "blocklisted". I 
think it would read better, and flows better with the naming of 
_is_extension_supported().


Thanks,

Liam Middlebrook

On 6/16/20 6:35 AM, André Hentschel wrote:
> Signed-off-by: André Hentschel <nerv at dawncrow.de>
> ---
>   dlls/winevulkan/make_vulkan | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/dlls/winevulkan/make_vulkan b/dlls/winevulkan/make_vulkan
> index 1dee769836f..6f92fcf22fa 100755
> --- a/dlls/winevulkan/make_vulkan
> +++ b/dlls/winevulkan/make_vulkan
> @@ -84,7 +84,7 @@ WINE_VULKAN_THUNKS_H = "vulkan_thunks.h"
>   EXT_BASE = 1000000000
>   EXT_BLOCK_SIZE = 1000
>   
> -BLACKLISTED_EXTENSIONS = [
> +BLOCKLISTED_EXTENSIONS = [
>       # Instance extensions
>       "VK_EXT_debug_report",
>       # Handling of VK_EXT_debug_report requires some consideration. The win32
> @@ -2607,7 +2607,7 @@ class VkRegistry(object):
>       def _is_extension_supported(self, extension):
>           # We disable some extensions as either we haven't implemented
>           # support yet or because they are for platforms other than win32.
> -        return extension not in BLACKLISTED_EXTENSIONS
> +        return extension not in BLOCKLISTED_EXTENSIONS
>   
>       def _mark_command_required(self, command):
>           """ Helper function to mark a certain command and the datatypes it needs as required."""
> @@ -2847,13 +2847,13 @@ class VkRegistry(object):
>                   return
>   
>               if not self._is_extension_supported(ext_name):
> -                LOGGER.debug("Skipping blacklisted extension: {0}".format(ext_name))
> +                LOGGER.debug("Skipping blocklisted extension: {0}".format(ext_name))
>                   return
>               elif "requires" in ext.attrib:
> -                # Check if this extension builds on top of another blacklisted
> +                # Check if this extension builds on top of another blocklisted
>                   # extension.
>                   requires = ext.attrib["requires"].split(",")
> -                if len(set(requires).intersection(BLACKLISTED_EXTENSIONS)) > 0:
> +                if len(set(requires).intersection(BLOCKLISTED_EXTENSIONS)) > 0:
>                       return
>   
>               LOGGER.debug("Loading extension: {0}".format(ext_name))
> 



More information about the wine-devel mailing list