[PATCH] windowscodecs/tests: Format ok() message for tests/ddsformat.c.

Ziqing Hui zhui at codeweavers.com
Thu Jun 18 21:32:22 CDT 2020


Thanks for finding the typo.

There are several different forms of ok message in ddsformat.c:

ok(assert, "%d: ...", i);

ok(assert, "[%d] ...", i);

ok(assert, "%d, ...", i);

ok(assert, "[%d, %d] ...", i, frame_index);

ok(assert, "[%d] ... for frame %d", i, frame_index);

ok(assert, "%d, %d ...", i, frame_index);

I want to format them to have one form, which makes me fell more comfortable when writing test code :p

On 6/19/20 8:48 AM, Esme Povirk (they/them) wrote:
> +    ok(hr == S_OK, "GetContaineluyinrFormat failed, hr %#x\n", hr);
>
> Small typo, I think.
>
> I'm also not sure if we need to be this picky about test messages.



More information about the wine-devel mailing list