[PATCH 1/2] user32/tests: Add test of ShowWindow with SW_SHOWNOACTIVATE

[Jactry Zeng]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi,

On 6/23/20 7:02 PM, Haidong Yu wrote:
> +    popup = CreateWindowExA(WS_EX_LEFT | WS_EX_LTRREADING | WS_EX_RIGHTSCROLLBAR | WS_EX_TOOLWINDOW | WS_EX_LAYERED | WS_EX_NOACTIVATE, "TestWindowClass", "layeredWnd",
This line looks pretty too long for me, probably I need a bigger monitor. :)

>
> +                            WS_CLIPSIBLINGS | WS_CLIPCHILDREN | WS_VISIBLE | WS_POPUP,
> +                            110, 110, 200, 200, hwnd, 0, 0, NULL);
> +
> +    SetLayeredWindowAttributes(popup, 0,150, LWA_ALPHA);
Is this really necessary for the test? And another nitpicking: please add a space after '0,'.
> +
> +    ShowWindow(hwnd, SW_SHOWNOACTIVATE);
> +    flush_events();
> +    ok(GetWindowLongA(popup, GWL_STYLE)&WS_VISIBLE, "The window should be visible\n");
Nitpicking: please add spaces before and after '&'.
And you might want to add a todo_wine to the test before you fix it.

> @@ -17955,6 +17985,7 @@ START_TEST(msg)
>      test_restore_messages();
>      test_invalid_window();
>  
> +    test_ShowOwnedPopups();
Should be test_show_no_active() here instead?
Also, is it possible to integrate the test into an existing function instead of creating a new one?


Thanks,
Jactry

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEENcHKmsHEqfZUIecDmyjwnocwYPQFAl7x/uEACgkQmyjwnocw
YPSh5wgAwzab01mt0L2odJBRY/NfcNhV1pSWFY9LSYpm8UexUUe+QnG220bl6Sow
wGIv0t2jZ7ZpwEeL3qgMc+0CQsUcWt4mB0FQumBlJbfl7k8hFzg7FupHL6yATLP7
B1FANxdohgPfv6Utu8W75EwkavupFmAg4IM0NZScJ2Ah/Y2SkH14Nokko0DKm6bA
QXT203kj8D4z0JnnV4gsPlToyr/Q9NNfFf4x5ZlN58L2z6DYsb8bv/JHJvt2q12t
gKxODqSC33eeX/pGr+sIm15PgkWCkka7+VGn8rim9HQEcXCz19mknvOrKJQfVcuM
iG/gUdgth/brE/u1YrcwTlHPcKdvYA==
=HYwf
-----END PGP SIGNATURE-----