[PATCH v6 04/12] msscript.ocx: Always detach the modules when changing the language.

Gabriel Ivăncescu gabrielopcode at gmail.com
Thu Jun 25 07:13:26 CDT 2020


Hi Jacek,

On 24/06/2020 18:32, Jacek Caban wrote:
> On 24.06.2020 16:16, Gabriel Ivăncescu wrote:
>> Signed-off-by: Gabriel Ivăncescu<gabrielopcode at gmail.com>
>> ---
>>
>> This is needed since put_Language not only calls Close but also the 
>> detached
>> modules return E_FAIL since they are orphaned.
> 
> 
> I don't see a test for that. If it's later in the series, it looks like 
> you could just move this patch.
> 
> 
> Thanks,
> 
> Jacek
> 

There are tests for that, but you're right that they get added with the 
other patches and I'll split them up and move this one. :-)



More information about the wine-devel mailing list