[PATCH 2/2] d3d9: Avoid a dead assignment in d3d9_device_SetStreamSource() (Coverity).
Henri Verbeet
hverbeet at codeweavers.com
Mon Mar 2 09:19:07 CST 2020
Signed-off-by: Henri Verbeet <hverbeet at codeweavers.com>
---
dlls/d3d9/device.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c
index 8d85a43523c..a651a63f02e 100644
--- a/dlls/d3d9/device.c
+++ b/dlls/d3d9/device.c
@@ -3688,17 +3688,18 @@ static HRESULT WINAPI d3d9_device_SetStreamSource(IDirect3DDevice9Ex *iface,
const struct wined3d_stream_state *stream;
state = wined3d_stateblock_get_state(device->state);
stream = &state->streams[stream_idx];
- wined3d_buffer = stream->buffer;
offset = stream->offset;
stride = stream->stride;
- }
-
- if (!buffer_impl)
wined3d_buffer = NULL;
+ }
else if (buffer_impl->draw_buffer)
+ {
wined3d_buffer = buffer_impl->draw_buffer;
+ }
else
+ {
wined3d_buffer = buffer_impl->wined3d_buffer;
+ }
hr = wined3d_stateblock_set_stream_source(device->update_state, stream_idx, wined3d_buffer, offset, stride);
if (SUCCEEDED(hr) && !device->recording)
--
2.20.1
More information about the wine-devel
mailing list