[PATCH 1/5] wined3d: Introduce wined3d_enum_adapters().
hverbeet at gmail.com
Mon Mar 2 09:39:34 CST 2020
On Mon, 2 Mar 2020 at 19:02, Zhiyi Zhang <zzhang at codeweavers.com> wrote:
> On 2020/3/2 23:19, Henri Verbeet wrote:
> > On Mon, 2 Mar 2020 at 11:54, Zhiyi Zhang <zzhang at codeweavers.com> wrote:
> >> @@ -2257,6 +2258,8 @@ HRESULT __cdecl wined3d_check_device_type(const struct wined3d *wined3d, UINT ad
> >> enum wined3d_format_id backbuffer_format_id, BOOL windowed);
> >> struct wined3d * __cdecl wined3d_create(DWORD flags);
> >> ULONG __cdecl wined3d_decref(struct wined3d *wined3d);
> >> +HRESULT __cdecl wined3d_enum_adapters(const struct wined3d *wined3d, UINT adapter_idx,
> >> + struct wined3d_adapter **adapter);
> > "struct wined3d_adapter * __cdecl wined3d_get_adapter(const struct
> > wined3d *wined3d, unsigned int idx);", right?
> Thanks, I will change that.
> I am a bit confused about the coding style here. Is the preference for wined3d
> function exports not to use HRESULT when possible/when there isn't a corresponding
> API call?
When possible, yes. More broadly, the idea is to avoid Win32 specific
types and conventions unless necessary, so that wined3d is for the
most part just a regular library.
More information about the wine-devel