[PATCH 3/5] wined3d: Remove some now redundant error handling from wined3d_device_set_*() functions.
z.figura12 at gmail.com
Wed Mar 4 11:06:56 CST 2020
On 3/4/20 9:17 AM, Henri Verbeet wrote:
> On Wed, 4 Mar 2020 at 03:26, Zebediah Figura <z.figura12 at gmail.com> wrote:
>> - if (FAILED(hr = wined3d_light_state_set_light(&device->state.light_state, light_idx, light, &object)))
>> - return hr;
>> + if (FAILED(wined3d_light_state_set_light(&device->state.light_state, light_idx, light, &object)))
>> + return;
> That doesn't look right.
> It may also be worth splitting this patch, but that's up to you.
The reason I did that is because the only remaining callers of
wined3d_device_set_light() don't check for errors anymore (and it's not
obvious to me that they'd gain anything by doing so.) But I can leave
the HRESULT signature if that'd be preferred.
More information about the wine-devel