[PATCH v3 1/2] kernelbase/locale: Implement comparison on top of official unicode weight tables

Fabian Maurer dark.shadow4 at web.de
Wed Mar 4 14:11:36 CST 2020

Hello Alexandre,

thanks for your reply.

> It's going to need more work

No problem, if you tell me what needs improvement.

> it's not clear how you are going to implement the remaining features with
your approach

What features exactly are you referring to?

> It also looks very inefficient

Why inefficient? We can't just compare character for character, since the
sortkey values don't always align like that. But then again, most strings
should get the "early exit", which is a lot cheaper.

> I'd suggest to concentrate on the tests first.

Well, the tests should already cover what's necessary. What do you think is

> Also as already mentioned, you should be working on the latest (Win10)
table, not the one from Win7.

Might have missed that, where was that? As i understood from your last mail,
the code needs to test and give the correct results for all windows version,
especially win10.
But why do we care about which tables are used as long as the results are the
same on all windows versions? The table version is only relevant when it comes
to differences between windows versions. The Win7 table was easier to handle,
so I picked that one.

Fabian Maurer

More information about the wine-devel mailing list