[PATCH v3 1/2] kernelbase/locale: Implement comparison on top of official unicode weight tables

[Alexandre Julliard]

Fabian Maurer <dark.shadow4 at web.de> writes:

> That's how I planned it - but not in the first version. As I said, I planned
> to split everything into manageable sizes. I could add all possible tests in
> one huge patch, but there's no real benefit to that.
>
>
> In short, I think the main problem here is that I want to split the
> implementation into multiple patches. I planned to add functionality one-by-
> one, covered with as many tests as I needed to give the code near full
> coverage. Is that a bad approach? If you want proof that the functionality can
> be added, please tell me how.

Splitting the implementation in multiple patches is definitely a good
thing, but if you want meaningful reviews you'll have to show more than
just the first step, otherwise we can't tell where you are going.

-- 
Alexandre Julliard
julliard at winehq.org