[PATCH v5 4/9] jscript: Create separate script dispatches for non-GLOBALMEMBERS named items.
jacek at codeweavers.com
Fri Mar 6 08:46:15 CST 2020
On 06.03.2020 14:48, Gabriel Ivăncescu wrote:
> Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
> dlls/jscript/engine.c | 7 +++++++
> dlls/jscript/jscript.c | 39 +++++++++++++++++++++++++++++++++++++++
> dlls/jscript/jscript.h | 2 ++
> 3 files changed, 48 insertions(+)
Thanks for splitting patches, it's much easier to read them now.
However, I think they will have to be reordered with this patch in the
end. Otherwise this patchset may break some scripts in a middle. For
example, if you apply the first 5 patches, scripts will use global
object, but host may try to interact with them using the new named item
object. If you set it to global object initially, everything will
continue to use global object, but in a new, named item aware, way. Once
all users are dealt with, you may add separated object with a simple
patch like this one.
More information about the wine-devel