[PATCH v2 3/5] wined3d: Move the fill mode to wined3d_rasterizer_state.

Zebediah Figura z.figura12 at gmail.com
Fri Mar 6 10:48:31 CST 2020

On 3/6/20 10:46 AM, Henri Verbeet wrote:
> On Fri, 6 Mar 2020 at 20:10, Zebediah Figura <z.figura12 at gmail.com> wrote:
>> Sure; I saw similar places using memcmp(), and figured since there
>> shouldn't be holes (at least on x86...) it'd be safe. Is it worth changing?
>> [And if so, is it worth changing e.g. glsl_blitter_args_compare()?]
> What we typically do for cases like that is to memset() the key with
> zeroes before initialising any fields. As in e.g.
> glsl_blitter_get_program(), to stick with the
> glsl_blitter_args_compare() example.

Duly noted; I'll send a patch to do that in
wined3d_device_apply_stateblock(). Thanks!

More information about the wine-devel mailing list