[PATCH v2 1/4] quartz/acmwrapper: Reimplement the ACM wrapper directly on top of strmbase_filter.

[Zebediah Figura]

On 3/10/20 12:06 PM, Alexandre Julliard wrote:
> Zebediah Figura <z.figura12 at gmail.com> writes:
> 
>> Signed-off-by: Zebediah Figura <zfigura at codeweavers.com>
>> ---
>>  dlls/quartz/acmwrapper.c       | 318 ++++++++++++++++++++++++++++-----
>>  dlls/quartz/tests/acmwrapper.c |  20 +--
>>  2 files changed, 288 insertions(+), 50 deletions(-)
> 
> Please remember to check for compiler warnings:
> 
> i686-w64-mingw32-gcc -c -o acmwrapper.cross.o acmwrapper.c -I. -I../../include -I../../include/msvcrt -D__WINESRC__ \
>   -DWINE_CROSS_PE -Wall -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body \
>   -Wignored-qualifiers -Wno-packed-not-aligned -Wshift-overflow=2 -Wstrict-prototypes -Wtype-limits \
>   -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith -Wlogical-op \
>   -fno-omit-frame-pointer -gdwarf-2 -gstrict-dwarf -Werror -g -O2 -fno-diagnostics-show-caret
> acmwrapper.c: In function ‘acm_wrapper_source_qc_Notify’:
> acmwrapper.c:427:13: error: ‘hr’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> cc1: all warnings being treated as errors
> make: *** [Makefile:202: acmwrapper.cross.o] Error 1
> 

My apologies. That one didn't show up for me, because I compile without
optimizations. I guess I'll need to keep an extra tree around :-/

(Maybe we can configure the testbot to use -Werror?)