[tools] testbot/LogUtils: Optimise the _GetLineKey() line cleanup.

Francois Gouget fgouget at codeweavers.com
Fri Mar 13 05:12:41 CDT 2020


Most line cleanups are mutually exclusive so stop trying after the first
successful attempt.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/lib/WineTestBot/LogUtils.pm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/testbot/lib/WineTestBot/LogUtils.pm b/testbot/lib/WineTestBot/LogUtils.pm
index bf933a007d..57229bc40d 100644
--- a/testbot/lib/WineTestBot/LogUtils.pm
+++ b/testbot/lib/WineTestBot/LogUtils.pm
@@ -1048,15 +1048,15 @@ sub _GetLineKey($)
   return undef if (!defined $Line);
 
   # Remove the line number
-  $Line =~ s/^([_a-z0-9]+\.c:)\d+:( Test (?:failed|succeeded inside todo block): )/$1$2/;
+  $Line =~ s/^([_a-z0-9]+\.c:)\d+:( Test (?:failed|succeeded inside todo block): )/$1$2/
 
   # Remove the crash code address: it changes whenever the test is recompiled
-  $Line =~ s/^(Unhandled exception: .* code) \(0x[0-9a-fA-F]{8,16}\)\.$/$1/;
-  # and the process id
-  $Line =~ s/^[0-9a-f]+:([_a-z0-9]+: unhandled exception [0-9a-fA-F]{8} at )[0-9a-fA-F]{8,16}$/$1/;
+  or $Line =~ s/^(Unhandled exception: .* code) \(0x[0-9a-fA-F]{8,16}\)\.$/$1/
+  # or the process id in Wine's exc_filter() lines
+  or $Line =~ s/^[0-9a-f]+:([_a-z0-9]+: unhandled exception [0-9a-fA-F]{8} at )[0-9a-fA-F]{8,16}$/$1/
 
   # The exact amount of data printed does not change the error
-  $Line =~ s/^([_.a-z0-9-]+:[_a-z0-9]* prints too much data )\(\d+ bytes\)$/$1/;
+  or $Line =~ s/^([_.a-z0-9-]+:[_a-z0-9]* prints too much data )\(\d+ bytes\)$/$1/;
 
   # Note: The 'done (258)' lines are modified by ParseWineTestReport() and
   #       no longer contain the pid. So they need no further change here.
-- 
2.20.1




More information about the wine-devel mailing list